Upgrade slang to 0.18.3 #1102
Merged
Upgrade slang to 0.18.3 #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newest version includes many performance improvements, and adds WASM support. It also adds a bunch of requested public APIs. This allows importing Slang from any WASM-compatible environment (NodeJS), at the cost of using ESM (or using `await import()` from CJS). That turns the calling utility `makeNamespacedInput()` to be `async`. Please let me know if I need to verify/run anything else.
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@nomicfoundation/slang@0.17.0 |
|
Should this be released under a minor? |
ernestognw
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1100
The
upgrades-corepackage has amakeNamespacedInputfunction, where near the end of its processing, it uses Slang to try to sanitize the source code further to remove non-struct NatSpec. This previously used Slang 0.17.Slang 0.18.x supports WASM and must be imported using
await import().To avoid converting the
makeNamespacedInputfunction to async which would result in breaking changes, this PR instead removes the sanitization step frommakeNamespacedInputand exposes an asynctrySanitizeNatSpecfunction that can be called separately. We then call this new function in thehardhat-upgradesplugin.