Options to change deploy and factory functions #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two new options that allow override of the deploy and factory functions. Kind is still used to identify the kind of proxy used, but this customization can manage variations of the proxy implementation and its constructor parameters. As a test case, and to show a concrete application of this change, I implemented a AccessManagedProxy. This proxy works like a UUPS (ERC1967) proxy, but before delegating the calls, checks with the access manager if the call is allowed.
Quick fix, I'm not expert enough in Typescript to make the correct type annotations
ericglau
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Thank you @gnarvaja for this PR! This looks like a good approach for allowing the proxy deployment to be overridden.
I made a few minor changes to the example proxy's comments and simplified the types for the new options.
The following would also be needed before we can merge this. Would you be interested in adding these? Thanks!
- A basic test for deploying a custom beacon proxy
- Add the new options in the documentation in
docs/modules/ROOT/pages/api-hardhat-upgrades.adoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #231
Adds two new options that allow override of the deploy and factory
functions.
Kind is still used to identify the kind of proxy used, but this
customization can manage variations of the proxy implementation and its
constructor parameters.
As a test case, and to show a concrete application of this change, I
implemented a AccessManagedProxy. This proxy works like a UUPS (ERC1967)
proxy, but before delegating the calls, checks with the access manager
if the call is allowed.