Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump Stylus to v0.7.0-beta.0 and alloy to v0.8.13 #430

Closed
wants to merge 15 commits into from

Conversation

bidzyyys
Copy link
Collaborator

@bidzyyys bidzyyys commented Dec 3, 2024

Resolves #424

PR Checklist

  • Tests
  • Documentation
  • Changelog

@bidzyyys bidzyyys self-assigned this Dec 3, 2024
@bidzyyys bidzyyys linked an issue Dec 3, 2024 that may be closed by this pull request
1 task
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 4783f23
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/674ee46cb10a9c000865ffda

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 14.91228% with 97 lines in your changes missing coverage. Please review.

Project coverage is 66.7%. Comparing base (504b083) to head (4783f23).

Files with missing lines Patch % Lines
contracts/src/token/erc1155/mod.rs 6.8% 54 Missing ⚠️
contracts/src/token/erc721/mod.rs 0.0% 19 Missing ⚠️
contracts/src/finance/vesting_wallet.rs 0.0% 11 Missing ⚠️
...ntracts/src/token/erc721/extensions/consecutive.rs 14.2% 6 Missing ⚠️
contracts/src/token/erc20/utils/safe_erc20.rs 0.0% 5 Missing ⚠️
contracts/src/token/erc20/mod.rs 66.6% 1 Missing ⚠️
contracts/src/token/erc721/extensions/metadata.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/access/control.rs 77.8% <ø> (+11.3%) ⬆️
contracts/src/access/ownable.rs 63.2% <100.0%> (+5.0%) ⬆️
contracts/src/access/ownable_two_step.rs 85.2% <100.0%> (+12.8%) ⬆️
...racts/src/token/erc1155/extensions/metadata_uri.rs 43.4% <ø> (+14.0%) ⬆️
contracts/src/token/erc20/extensions/capped.rs 18.5% <ø> (ø)
contracts/src/token/erc20/extensions/metadata.rs 4.1% <ø> (ø)
contracts/src/token/erc20/extensions/permit.rs 0.0% <ø> (ø)
contracts/src/token/erc721/extensions/burnable.rs 100.0% <100.0%> (ø)
...ontracts/src/token/erc721/extensions/enumerable.rs 75.1% <100.0%> (ø)
...ntracts/src/token/erc721/extensions/uri_storage.rs 60.4% <100.0%> (+14.8%) ⬆️
... and 10 more

... and 1 file with indirect coverage changes

@bidzyyys
Copy link
Collaborator Author

bidzyyys commented Dec 3, 2024

Blocked by OpenZeppelin/koba#14

@bidzyyys
Copy link
Collaborator Author

bidzyyys commented Dec 4, 2024

Superseded by #433

@bidzyyys bidzyyys closed this Dec 4, 2024
@bidzyyys bidzyyys deleted the build/bump-stylus-sdk branch December 4, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build]: Bump Stylus SDK to v0.7.0-beta.1 and alloy to v0.8.14
1 participant