Closed
Conversation
Collaborator
|
Superseded by #58 (applied to refactored codebase). Thanks for the fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Bug Fix: Case-sensitive protected tools check (lib/deduplicator.ts)
The protectedTools array contains lowercase names (['task', 'todowrite', 'todoread', 'prune']), but tool names from providers can be mixed case (e.g., "Task"). The case-sensitive includes() check caused protected tools to be incorrectly deduplicated.
Fix: Normalize both sides to lowercase before comparison.
Bug Fix: Cross-session deduplication (lib/fetch-wrapper/)
The fetch wrapper was using ALL tool IDs from the global state.toolParameters cache for deduplication, which could cross-contaminate sessions if multiple sessions ran concurrently.
Fix:
Bug Fix: Unbounded memory growth (lib/tool-cache.ts)
The state.toolParameters cache was never cleared, causing memory to grow indefinitely over long-running sessions.
Fix: Added trimToolParametersCache() that limits cache to 500 entries with FIFO eviction.