Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get app starting on heroku #1

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

Br3nda
Copy link

@Br3nda Br3nda commented Jan 27, 2021

Not sure why the dockerfile wasn't starting the entry point on heroku -- so I made it simpler. Just a simple shell script
then put the longer incantation to start it in that script. I added the $PORT variable. Heroku sets this to tell your app what to start on.

I've also added to the README

@Br3nda
Copy link
Author

Br3nda commented Jan 27, 2021

Thank you to @sarafalamaki for getting git submodules working for me

@Br3nda
Copy link
Author

Br3nda commented Jan 27, 2021

this is deployed happily to https://testrules.herokuapp.com/spec

@Br3nda
Copy link
Author

Br3nda commented Jan 27, 2021

ooo one more thing. I need to do this using the heroku cli

heroku stack:set container --app testrules

@sarafalamaki
Copy link
Contributor

Thanks so much for this @Br3nda! I'm not sure why the test is not passing. Is it a permission thing?

@Br3nda
Copy link
Author

Br3nda commented Feb 3, 2021

@sarafalamaki there's a step with this;

    - uses: docker/build-push-action@v1
      with:
        username: ${{ secrets.DOCKER_USERNAME }}
        password: ${{ secrets.DOCKER_PASSWORD }}
        registry: ${{ secrets.DOCKER_REGISTRY }}
        repository: openfisca_nsw_api
        tags: latest
        dockerfile: openfisca_nsw_api.Dockerfile

I'm not sure why you're doing this on every push and every pull request.

Should we instead change it to only push to the docker registry when it's a merge into our main branch?

@Br3nda
Copy link
Author

Br3nda commented Feb 3, 2021

i think you want to build it on every PR and push, but only publish it if it's been accepted into the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants