-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get app starting on heroku #1
base: master
Are you sure you want to change the base?
Conversation
Use heroku.yml to tell heroku to use the dockerfile
Thank you to @sarafalamaki for getting git submodules working for me |
this is deployed happily to https://testrules.herokuapp.com/spec |
ooo one more thing. I need to do this using the heroku cli
|
Thanks so much for this @Br3nda! I'm not sure why the test is not passing. Is it a permission thing? |
@sarafalamaki there's a step with this;
I'm not sure why you're doing this on every push and every pull request. Should we instead change it to only push to the docker registry when it's a merge into our main branch? |
i think you want to build it on every PR and push, but only publish it if it's been accepted into the master branch. |
Not sure why the dockerfile wasn't starting the entry point on heroku -- so I made it simpler. Just a simple shell script
then put the longer incantation to start it in that script. I added the $PORT variable. Heroku sets this to tell your app what to start on.
I've also added to the README