layers/meta-opentrons: fix jupyter install in kirkstone #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
too big
This hopefully should be the last step to getting everything working and sane. We don't need the packagegroup (something was breaking everything anyway) and we need to fix up a couple things in the install process so the unit goes in the same place as everything else, actually runs jupyter directly so journald logging tags it properly, and we get the user package path.
sfoster1
changed the title
vegano1
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, meta-jupyter on kirkstone has a weird package architecture that does not properly represent jupyter's dependencies. They seem to want you to install a packagegroup instead of the jupyter meta-package, since the meta-package now doesn't actually root a tree of all jupyter's deps. The problem is that (a) the package group wants pydot which needs graphviz from meta-openembedded which seems straight up broken and (b) even if you skip that it makes the image fail for reasons I don't fully understand.
Instead, we can just iterate on adding deps exclusively to our recipe that also depends on the jupyter metapackage until the thing can actually run notebooks, and fix up some other recipe and unit issues while we're at it.
This pr is successful if a build lets you run python commands in a notebook, and also pop a terminal and run terminal commands.