fix(app): support special cased slot name copy #16823
Merged
+42
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
requested review from
ecormany,
sfoster1,
TamarZanzouri,
smb2268 and
a team
mjhuff
force-pushed
the
app_fix-waste-chute-slot-recovery
branch
from
0b36c5c to
5b2fe3c
Compare
sfoster1
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3585
Overview
We recently refactored the way we handle display text, but there's never been a clear mechanism for handling waste chute/trash bin copy. This PR adds that. Instead of showing "Slot Waste Chute" or "Slot Trash Bin", it probably makes more sense to show just the name of the special cased
slotName.Current Behavior
Fixed Behavior
Test Plan and Hands on Testing
Changelog
Risk assessment
low