Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): no longer put off-deck button behind ff #14061

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Nov 30, 2023

closes RAUT-887

Overview

To prepare for the 1st 8.0 release candidate, this is to no longer put the off-deck button behind the ff and then rename the ff to only encompass multi-tip support

Test Plan

Create a flex protocol and go to deck setup and see that the off deck button is visible and works correctly!

Create a protocol for the ot-2 and notice the off-deck button there as well.

Changelog

  • remove off-deck button from being behind a feature flag and rename the ff to something that doesn't include the off-deck button

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team November 30, 2023 13:32
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #14061 (89b10e5) into edge (07b292c) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #14061   +/-   ##
=======================================
  Coverage   70.51%   70.51%           
=======================================
  Files        2507     2507           
  Lines       71163    71161    -2     
  Branches     8906     8905    -1     
=======================================
  Hits        50178    50178           
+ Misses      18806    18804    -2     
  Partials     2179     2179           
Flag Coverage Δ
protocol-designer 45.03% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tocol-designer/src/components/DeckSetupManager.tsx 0.00% <ø> (ø)
protocol-designer/src/feature-flags/reducers.ts 62.50% <100.00%> (ø)
protocol-designer/src/feature-flags/types.ts 100.00% <ø> (ø)
protocol-designer/src/feature-flags/selectors.ts 58.33% <50.00%> (ø)

@jerader jerader requested review from ncdiehl11 and mjhuff December 1, 2023 16:15
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🥳

@jerader jerader merged commit 42194c6 into edge Dec 6, 2023
15 of 16 checks passed
@jerader jerader deleted the pd_move-away-from-ff branch December 6, 2023 18:21
ncdiehl11 pushed a commit that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants