Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): add biorad pcr plate as compatible with adapter #14112

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Dec 6, 2023

Overview

As per some discussions in the proj ot3 science slack channel, we needed to add the biorad hardplate as compatible with the H-S 96 channel adapter

Test Plan

Create a flex or ot-2 protocol, add a heater-shaker. go to the deck setup and add a PCR 96 well adapter on top of the heater-shaker. Then see that the biorad plate is selectable to go on top of the adapter.

Changelog

  • add compatibility to the biorad labware to go on top of the pcr 96 well adapter

Review requests

see test plan

Risk assessment

low

@jerader jerader requested review from a team and koji December 6, 2023 18:09
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #14112 (abd0037) into edge (2a911e3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14112      +/-   ##
==========================================
- Coverage   70.36%   70.36%   -0.01%     
==========================================
  Files        1634     1634              
  Lines       54509    54510       +1     
  Branches     4035     4035              
==========================================
  Hits        38355    38355              
- Misses      15453    15454       +1     
  Partials      701      701              
Flag Coverage Δ
protocol-designer 44.56% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...l-designer/src/utils/labwareModuleCompatibility.ts 42.42% <0.00%> (-1.33%) ⬇️

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed the test plan and the sandbox worked as expected.
The changes look good to me.

@jerader jerader merged commit 6b83ab9 into edge Dec 6, 2023
21 of 22 checks passed
@jerader jerader deleted the pd_add-biorad-compatibility branch December 6, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants