-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(step-generation): update nozzles in robotState not from initialRobotState #14155
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #14155 +/- ##
=======================================
Coverage 70.36% 70.37%
=======================================
Files 2481 2481
Lines 70325 70332 +7
Branches 8780 8780
=======================================
+ Hits 49486 49495 +9
+ Misses 18687 18685 -2
Partials 2152 2152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
const configureNozzleLayoutCommandReset = getConfigureNozzleLayoutCommandReset( | ||
args.pipette, | ||
prevNozzles | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't actually needed since the robot will reset the nozzles to "All" at the end of each run. So i removed it to clean it up. Plus it should go in generateRobotStateTimeline
instead since that's where the final drop tip commands get emitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much cleaner now! 😄 🧹
console.log('args.nozzles', args.nozzles) | ||
console.log('state nozzles', stateNozzles) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover console logs
Overview
There was a PD bug where if you have multiple column pick up steps followed by a full tip pick up step, it'd error. This is for 96-channel! But this PR fixes it and cleans up the reset command
Test Plan
Test by adding 2 column pick up transfer steps followed by a Full tip pick up step. See that it doesn't error. Check tip state and see that it updates correctly. Download the protocol and see that there are 2
configureNozzleLayout
commands for column and then for AllChangelog
configureNozzleLayout
state update.configureNozzleLayout
reset command, it isn't needed since the robot will reset the nozzles after each runReview requests
see test plan
Risk assessment
low