Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): loadLabware support for off-deck labware #14164

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Dec 11, 2023

closes RQA-2058

Overview

The loadLabware command's labware location logic didn't include loading labware off-deck. this is because loading labware off-deck wasn't a PD feature until now in 8.0.

Test Plan

Create a flex or ot-2 protocol. Click on the design tab and clock on the "off deck labware" button. Add a labware off-deck. Download the protocol. Look at the JSON file and see that the loadLabware command is correct where the location is "location": "offDeck"

Changelog

extend offDeck location in the component

Review requests

see test plan

Risk assessment

low

@jerader jerader requested review from a team, koji and mjhuff December 11, 2023 20:52
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #14164 (29873c3) into edge (8a9330c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14164      +/-   ##
==========================================
- Coverage   70.40%   70.40%   -0.01%     
==========================================
  Files        2510     2510              
  Lines       71191    71193       +2     
  Branches     8967     8968       +1     
==========================================
  Hits        50122    50122              
- Misses      18877    18878       +1     
- Partials     2192     2193       +1     
Flag Coverage Δ
protocol-designer 44.53% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ol-designer/src/file-data/selectors/fileCreator.ts 66.66% <0.00%> (-1.63%) ⬇️

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
offDeck showed up the place you mentioned.

@jerader jerader merged commit 918284a into edge Dec 12, 2023
21 of 22 checks passed
@jerader jerader deleted the pd_offdeck-load-labware-fix branch December 12, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants