fix(protocol-designer): getIsSlotEmpty logic util fix for modules and… #14188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
commented
Dec 13, 2023
Comment on lines
-164
to
-168
| ...values(initialDeckSetup.modules).filter((moduleOnDeck: ModuleOnDeck) => | ||
| slot.includes(moduleOnDeck.slot) | ||
| ...values(initialDeckSetup.modules).filter( | ||
| (moduleOnDeck: ModuleOnDeck) => moduleOnDeck.slot === slot | ||
| ), | ||
| ...values(initialDeckSetup.labware).filter((labware: LabwareOnDeckType) => | ||
| slot.includes(labware.slot) |
There was a problem hiding this comment.
this old logic only works for a Flex since the slot numberings are a grid system. the new logic takes into account the Ot-2 slots.
koji
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… labware
Overview
Followup to my last PR that was fixing the
getIsSlotEmptylogic for the addressable areas. This PR fixes the logic for labware and modules since i noticed there were still issues with some slots not being full but the util thinking they are full.Test Plan
First test with creating an ot-2 protocol. Mess around with adding/deleting modules in different locations and make sure the slot is full when it really is full! The case in particular that was erroring was if a TC is attached and trying to add a module to slot 1, the util thought slot 1 was full even though slots 7,8,10,11 were full
Then test with creating a flex protocol and do the same thing.
Changelog
includes()Review requests
see test plan
Risk assessment
low