Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] chore(app-shll,app-shll-odd): update electron version to v28 #14264

Closed
wants to merge 13 commits into from

Conversation

koji
Copy link
Contributor

@koji koji commented Dec 21, 2023

Overview

update electron version to v28 and remove usb-detection

close RAUT-

Test Plan

Changelog

Review requests

Risk assessment

@koji koji added the WIP label Dec 22, 2023
@koji
Copy link
Contributor Author

koji commented Dec 22, 2023

ToDo

  • Mac
  • Windows
  • Linux
  • ODD mode
  • ODD
  • Fix tests
  • Check OT-2 USB
  • Check Redux Devtools
  • Check React Devtools
  • Solve ODD time-out issue
  • Update CI yaml
    • node version
    • add lib for usb (ubuntu)

@koji
Copy link
Contributor Author

koji commented Dec 22, 2023

React Devtools

  1. Go ~/Library/Application Support/Opentrons/extensions
  2. Download the following zip file and unzip it.
  3. Replace all files under fmkadmapgofadopljbjfkapdkoienih with the above unzipped files
  4. Restart Desktop app

facebook/react#25843 (comment)
fmkadmapgofadopljbjfkapdkoienihi.zip

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc61df7) 68.05% compared to head (3d882da) 68.07%.
Report is 34 commits behind head on edge.

❗ Current head 3d882da differs from pull request most recent head 7199feb. Consider uploading reports for the commit 7199feb to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14264      +/-   ##
==========================================
+ Coverage   68.05%   68.07%   +0.01%     
==========================================
  Files        2508     2509       +1     
  Lines       71371    71366       -5     
  Branches     9060     9063       +3     
==========================================
+ Hits        48575    48582       +7     
+ Misses      20693    20681      -12     
  Partials     2103     2103              
Flag Coverage Δ
components 50.34% <ø> (-0.03%) ⬇️
g-code-testing 96.48% <ø> (+0.04%) ⬆️
protocol-designer 34.93% <ø> (ø)
react-api-client 65.73% <ø> (ø)
shared-data 75.05% <ø> (-0.03%) ⬇️
step-generation 86.90% <ø> (ø)
system-server 96.04% <ø> (+0.01%) ⬆️
update-server 63.58% <ø> (+0.07%) ⬆️
usb-bridge 76.94% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app-shell-odd/src/main.ts 0.00% <ø> (ø)
app-shell-odd/src/restart.ts 0.00% <ø> (ø)
app-shell-odd/src/system-update/index.ts 0.00% <ø> (ø)
app-shell-odd/src/systemd.ts 16.00% <ø> (ø)
app-shell-odd/src/ui.ts 0.00% <ø> (ø)
app-shell-odd/src/update.ts 36.58% <ø> (ø)
app-shell/src/system-info/index.ts 89.28% <ø> (-0.72%) ⬇️
app-shell/src/system-info/usb-devices.ts 89.47% <ø> (+4.85%) ⬆️
app-shell/src/ui.ts 0.00% <ø> (ø)

... and 105 files with indirect coverage changes

@koji
Copy link
Contributor Author

koji commented Jan 19, 2024

moved -> #14314

@koji koji closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant