fix(protocol-designer,components): fix dropdown menu expands direction issue #16841
+29
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issue fix dropdown menu expand direction issue close RQA-
|
Still seeing issue on move labware dropdown |
|
is this expected? i guess we may want to give the dropdown menu a max height or something? Screen.Recording.2024-11-14.at.16.19.27.mov |
that is an expected behavior because DropdownMenu's height is set to display 10 items(Mel's request.) |
jerader
approved these changes
Nov 15, 2024
@ncdiehl11
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix dropdown menu expands direction issue.
update DropdownMenu's prop to make things more understandable.
modify, Toolbox's height.
https://opentrons.slack.com/archives/C07E9T2NAQK/p1731536325870079?thread_ts=1731525319.924009&cid=C07E9T2NAQK
For LiquidToolbox, the nested structure is deeper than others (expected) but the UI layout is fixed so set menuPlacement="bottom". SelectModules and SelectFixtures are the same.
close RQA-3563
Test Plan and Hands on Testing
Changelog
Review requests
low
Risk assessment