Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data): RABR-669 add biorad pcr plate compatibility with tough_pcr_lid #16849

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

rclarke0
Copy link
Contributor

Overview

Adds compatibility between biorad_96_wellplate_200ul_pcr and opentrons_tough_pcr_auto_sealing_lid with stacking z offset

Test Plan and Hands on Testing

  • Tested on thermocycler in ABR

Changelog

  • added biorad_96_wellplate_200ul_pcr stacking offset to shared data file

Review requests

Risk assessment

@rclarke0 rclarke0 requested a review from a team as a code owner November 15, 2024 16:13
@rclarke0 rclarke0 requested a review from CaseyBatten November 15, 2024 16:14
@rclarke0 rclarke0 changed the title fix(shared-data): add biorad pcr plate compatibility to tc lid fix(shared-data): RABR-669 add biorad pcr plate compatibility with tough_pcr_lid Nov 15, 2024
Copy link
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Rhyann. Just a question down below on if we have it marked down anywhere regarding the measurement of our stacking offset.

"biorad_96_wellplate_200ul_pcr": {
"x": 0,
"y": 0,
"z": 8.08
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it documented anywhere where this offset was measured from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - measured with drawings of biorad plate and tc lid and fact checked with calipers: https://docs.google.com/spreadsheets/d/1OvHZoWXwx44dLUkgkJcvXuyjYH_XMvnnmPL7J4onW8M/edit?gid=1340462902#gid=1340462902

@rclarke0 rclarke0 merged commit 5ed800e into edge Nov 20, 2024
73 checks passed
@rclarke0 rclarke0 deleted the add-biorad-to-tc-lid-definition branch November 22, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants