fix(protocol-designer): add white space below deck and remove module tag #16856
+41
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
commented
Nov 15, 2024
| @@ -57,13 +54,6 @@ export function SlotHover(props: SlotHoverProps): JSX.Element | null { | |||
| deckDef.cutoutFixtures | |||
| ) ?? 'cutoutD1' | |||
|
|
|||
| const debouncedSetHover = useCallback( | |||
There was a problem hiding this comment.
i believe that since there is white space hardcoded underneath the deck map, debounce is no longer needed, but please double check @koji !
ncdiehl11
reviewed
Nov 18, 2024
|
I think flickering often occurs when hovering over an adjacent slot that has nothing. However, it also happens with none -> none, so I’m not sure about the exact cause. I thought the issue cause from the size change but none -> none case has the same flickering issue. |
jerader
force-pushed
the
pd_fix-deck-map-stuff
branch
from
5adc9c7
to
efb2e2a
Compare
|
@ncdiehl11 @koji, i think the flickering issue is not really a bug since there is white space between the hover containers on the deck map. Will ask in the PD weekly tomorrow though what people think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-3604 RQA-3603
Overview
Remove the module tags in protocol steps because they're too small and can't be read
Add white space below protocol overview's deck map when viewport shows 1 column
Test Plan and Hands on Testing
Test slot details in protocol overview when screensize is small enough for 1 column. make sure there is no flickering
Then go to protocol steps and make some steps and see that the module tag is removed from the labware
Changelog
Risk assessment
low