fix(protocol-designer): fix slotOverflowMenu for tipracks on adapters and update path selection for trash bin #16908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tiprack on adapter fix RQA-3607
jerader
reviewed
Nov 20, 2024
Comment on lines
117
to
119
| const isTiprackAdapter = | ||
| labwareOnSlot?.id.includes('tiprack') && isLabwareAnAdapter | ||
|
|
There was a problem hiding this comment.
what you have works but is a bit brittle, there could be an event where we add a new labware that meets those conditions that we want to add liquid to. i recommend instead, searching for the quirk tiprackAdapterFor96Channel. you can find it from labwareOnSlot.def.parameters
There was a problem hiding this comment.
here's the file path for the adapter definition so you can check it out shared-data/labware/definitions/2/opentrons_flex_96_tiprack_adapter/1.json
syao1226
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-3607
Overview
In this PR, I updated the
SlotOverflowMenuto disallow adding liquid and renaming labware for tipracks on adapters. Additionally, I updatedupdatePatchOnWellRatioChangeto check if thedispense_labwareincludes 'movableTrash' or 'fixedTrash'. This fixes the issue where the consolidate path could not be selected when dispensing liquid into the trash bin.Test Plan and Hands on Testing
Changelog
isTiprackAdapterinSlotOverflowMenuto check if the slot is a tiprack adapter.Review requests
Risk assessment