Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Fix gantry not homing when no labware in gripper jaws during Error Recovery #17201

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Jan 7, 2025

Closes RQA-3822

Overview

After the 8.2 release and some subsequent refactors, we were able to tie the gripper command sequencing directly to CTAs instead of utilizing an implicit execution sequence via a useEffect. Part of that command sequencing includes gripper homing, which occurs roughly when the user is prompted to confirm whether labware is currently in the gripper jaws. We (aka me) forgot to add the home command for the "no labware in jaws" case, as the homing should occur regardless of whether or not labware is in the jaws.

This PR just adds the explicit homing command to the "no labware in jaws" option, preventing fatal errors that occur after gripper recovery involving axes with unknown positioning.

Test Plan and Hands on Testing

  • Go through the gripper error flow, selecting "no labware in jaws". On edge, there won't be any homing behavior that occurs. On this branch, there should be a home.
  • Verified the run does not terminally fail after completing gripper recovery.

Changelog

  • Fixed gripper recovery sometimes resulting in the run terminally failing after completing recovery.

Risk assessment

low

@mjhuff mjhuff requested a review from a team as a code owner January 7, 2025 17:56
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, that makes sense

Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you!

@mjhuff mjhuff merged commit 696d2e4 into chore_release-8.3.0 Jan 7, 2025
30 checks passed
@mjhuff mjhuff deleted the app_fix-no-home-no-labware-in-jaws branch January 7, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants