Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(robot-server): Better errors for bad wpa2 pass #17203

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Jan 7, 2025

We pipe errors from nmcli straight to the display when we get them. NMCLI has famously awful errors. We don't want to always squash them, because they could be useful, but in the case of a mis-entered WPA2 PSK, we can be pretty sure that's the problem.

This will now say "check your wifi credentials"
Screenshot 2025-01-07 at 4 46 15 PM

Testing

  • Connect to a wifi network and purposefully enter the wrong password; you should get a less awful message. Note that this only actually works if you're disconnected from wifi when you try to connect; if you're connected to wifi and then try and connect to a network and use the wrong password, you just don't get a result because the request went out over the original wifi network which got disconnected.

It's the same code on the flex, ot-2 on the desktop (the ODD has a different message).
Closes RSQ-3

We pipe errors from nmcli straight to the display when we get them.
NMCLI has famously awful errors. We don't want to always squash them,
because they could be useful, but in the case of a mis-entered WPA2 PSK,
we can be pretty sure that's the problem.

Closes RSQ-3
@sfoster1 sfoster1 requested a review from a team as a code owner January 7, 2025 21:06
@sfoster1 sfoster1 merged commit eeb7a02 into chore_release-8.3.0 Jan 7, 2025
13 checks passed
@sfoster1 sfoster1 deleted the RSQ-3-better-wifi-error-message branch January 7, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants