fix(app): Fix gripper calibration copy during exit #17220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3832
Overview
The
MovePin
step of gripper (re)calibration flows has extra special movement copy logic, since we must account for the robot being in motion due to calibration and due to homing the gantry during an exit event. However, as far as I can tell, never at any point have we ever set the robot toisExiting
when we start exiting. Woops.The reason this doesn't impact other steps in the calibration flow is instead of checking
isExiting
when we exit, we checkisRobotMoving
to show the exit modal, since there aren't any other competing movement commands...?Anyway, there's a lot of refactoring we should do for these flows, and the amount of work required to polish them is definitely a sustaining task, see EXEC-1081.
Current Behavior
PXL_20250108_164825035.mp4
Fixed Behavior
Screen.Recording.2025-01-08.at.1.19.34.PM.mov
Test Plan and Hands on Testing
Changelog
Risk assessment
low