Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Fix gripper calibration copy during exit #17220

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Jan 8, 2025

Closes RQA-3832

Overview

The MovePin step of gripper (re)calibration flows has extra special movement copy logic, since we must account for the robot being in motion due to calibration and due to homing the gantry during an exit event. However, as far as I can tell, never at any point have we ever set the robot to isExiting when we start exiting. Woops.

The reason this doesn't impact other steps in the calibration flow is instead of checking isExiting when we exit, we check isRobotMoving to show the exit modal, since there aren't any other competing movement commands...?

Anyway, there's a lot of refactoring we should do for these flows, and the amount of work required to polish them is definitely a sustaining task, see EXEC-1081.

Current Behavior

PXL_20250108_164825035.mp4

Fixed Behavior

Screen.Recording.2025-01-08.at.1.19.34.PM.mov

Test Plan and Hands on Testing

  • See videos

Changelog

  • Fixed incorrect copy appearing when exiting the gripper calibration flows during the "move pin" step.

Risk assessment

low

@mjhuff mjhuff requested a review from a team as a code owner January 8, 2025 18:34
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change makes sense to me.

Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EZ!

@mjhuff mjhuff merged commit 0fa2cfc into chore_release-8.3.0 Jan 8, 2025
36 checks passed
@mjhuff mjhuff deleted the app_fix-gripper-cal-exit branch January 8, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants