Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): yaml upload and download artifact version to 4 #17229

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jan 9, 2025

Overview

github actions upload-artifact and download-artifact v3 was deprecated so this updates to v4.

Test Plan and Hands on Testing

Review yaml and make sure the artifact is correctly built

Changelog

update the download and upload artifact version from 3 to 4

Risk assessment

low

@jerader jerader requested a review from a team as a code owner January 9, 2025 18:13
@jerader jerader requested review from y3rsh and sfoster1 January 9, 2025 18:16
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works it works!

@jerader jerader merged commit d3b1b9c into edge Jan 9, 2025
18 checks passed
@jerader jerader deleted the pd_yaml-github-artifact-update branch January 9, 2025 18:26
sfoster1 added a commit that referenced this pull request Jan 9, 2025
Came up for PD ( #17229 ), probably will come up here too. Let's get
ahead of it. If the build passes this should be fine.
Laura-Danielle pushed a commit that referenced this pull request Jan 9, 2025
… 4 (#17229)

github actions upload-artifact and download-artifact v3 was deprecated
so this updates to v4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants