fix(app): fix terminal banner render state

[mjhuff]

Closes RQA-3840

Overview

This PR fixes conditional logic that causes the "run succeeded" banner to render momentarily when in actuality, an error banner should render. Checking if the commandErrorList is null is not sufficient to render the success banner appropriately, because the commandErrorList is null when the network request has not yet completed. Instead, we should check if the length of the list is 0.

A lower-latency solution would be to add the /runs/:runId/commandErrors resource to notifications, which would also simplify the conditional logic, see EXEC-1083.

Current Behavior

Screen.Recording.2025-01-10.at.9.39.41.AM.mov

Fixed Behavior

Screen.Recording.2025-01-10.at.9.33.08.AM.mov

Test Plan and Hands on Testing

• See videos.

Changelog

• Fixed the success banner sometimes flickering when a run fails on the desktop app.

Risk assessment

low - easy to validate.

[TamarZanzouri]

LGTM!

[sfoster1]

Yeah, that looks appropriate.