fix(app): Inject labware definitions into Error Recovery #17248
Merged
+116
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsByUri We currently build an empty dict if the network request has not yet completed, which isn't incorrect, but doing so leads to confusing behavior using the hook API. By returning null, we more accurately hint at loading state.
TamarZanzouri
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3814
Overview
Not too long ago, we implemented the
/runs/runId/labware_definitionsresource on the FE and started using it in Error Recovery. Because we now get labware definitions asynchronously (instead of the old command scanning synchronous behavior), we get blippy UX while the request is still loading.This PR injects the labware definitions into Error Recovery, gating ER rendering while the request is ongoing.
Like 90% of the diff is type/variable name refactoring. See
app/src/organisms/ErrorRecoveryFlows/index.tsxfor the functional changes.Current Behavior
Screen.Recording.2025-01-10.at.2.28.53.PM.mov
Fixed Behavior
Screen.Recording.2025-01-10.at.2.25.07.PM.mov
Test Plan and Hands on Testing
Changelog
Risk assessment
low - mainly type stuff