-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pending]feat(protocol-designer): introduce alias to avoid using ../../../ #17539
Draft
koji
wants to merge
7
commits into
edge
Choose a base branch
from
feat_support-alias-in-pd
base: edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduce alias to avoid using ../../../ close AUTH-
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
introduce alias to avoid using ../../../
close AUTH-
pending
there are many typing issues after updating import paths
@ncdiehl11 @syao1226
target files are ↓
https://docs.google.com/spreadsheets/d/1PRPFkcfreqQRhDXdD_WCKXbX_xlzkrYPUW0yhOLW6zQ/edit?usp=sharing
step 1
check out branch
step 2
change the above files status from
yet
towip
please do this to avoid editing the same file.
step 3
update the path like below.
if an import statement using
../../
or more, using/protocol-designer/
I think we can keep
./
and../
since it's easy to track.please see https://github.com/Opentrons/opentrons/pull/17539/files.
I updated Settings/index.tsx and its test as a sample.
if you have any questions about this, feel free to reach out to me.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment