Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pending]feat(protocol-designer): introduce alias to avoid using ../../../ #17539

Draft
wants to merge 7 commits into
base: edge
Choose a base branch
from

Conversation

koji
Copy link
Contributor

@koji koji commented Feb 14, 2025

Overview

introduce alias to avoid using ../../../

close AUTH-

pending

there are many typing issues after updating import paths

@ncdiehl11 @syao1226
target files are ↓
https://docs.google.com/spreadsheets/d/1PRPFkcfreqQRhDXdD_WCKXbX_xlzkrYPUW0yhOLW6zQ/edit?usp=sharing

step 1

check out branch

step 2

change the above files status from yet to wip
please do this to avoid editing the same file.

step 3

update the path like below.
if an import statement using ../../ or more, using /protocol-designer/
I think we can keep ./ and ../ since it's easy to track.

please see https://github.com/Opentrons/opentrons/pull/17539/files.
I updated Settings/index.tsx and its test as a sample.

if you have any questions about this, feel free to reach out to me.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

introduce alias to avoid using ../../../

close AUTH-
@koji koji requested review from ncdiehl11 and syao1226 February 14, 2025 22:09
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 25.62%. Comparing base (1bcbccb) to head (6a0e87c).

Files with missing lines Patch % Lines
.eslintrc.js 0.00% 4 Missing ⚠️
...r/src/pages/CreateNewProtocolWizard/WizardBody.tsx 0.00% 3 Missing ⚠️
...ProtocolSteps/StepForm/PipetteFields/PathField.tsx 0.00% 3 Missing ⚠️
...tocol-designer/src/labware-defs/__mocks__/utils.ts 0.00% 2 Missing ⚠️
...load-file/migration/utils/v1LabwareModelToV2Def.ts 0.00% 1 Missing ⚠️
...rganisms/WellOrderModal/WellOrderVisualization.tsx 0.00% 1 Missing ⚠️
...pages/Designer/DeckSetup/SelectedLabwareRender.tsx 0.00% 1 Missing ⚠️
...Designer/DeckSetup/SelectedModuleLabwareRender.tsx 0.00% 1 Missing ⚠️
...designer/src/step-forms/actions/additionalItems.ts 0.00% 1 Missing ⚠️
...rotocol-designer/src/step-forms/actions/modules.ts 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17539      +/-   ##
==========================================
- Coverage   25.70%   25.62%   -0.08%     
==========================================
  Files        2843     2843              
  Lines      218884   219461     +577     
  Branches    17947    17950       +3     
==========================================
- Hits        56268    56247      -21     
- Misses     162601   163199     +598     
  Partials       15       15              
Flag Coverage Δ
app 3.41% <0.00%> (-0.02%) ⬇️
step-generation 4.37% <5.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../file-data/__fixtures__/createFile/commonFields.ts 100.00% <ø> (ø)
.../file-data/__fixtures__/createFile/engageMagnet.ts 1.12% <ø> (ø)
...src/file-data/__fixtures__/createFile/noModules.ts 0.52% <ø> (ø)
...src/file-data/__fixtures__/createFile/v6Fixture.ts 0.31% <ø> (ø)
...src/file-data/__fixtures__/createFile/v7Fixture.ts 100.00% <ø> (ø)
protocol-designer/src/file-data/reducers/index.ts 68.22% <ø> (ø)
...tocol-designer/src/file-data/selectors/commands.ts 54.45% <ø> (ø)
...ol-designer/src/file-data/selectors/fileCreator.ts 84.21% <ø> (ø)
...col-designer/src/file-data/selectors/fileFields.ts 100.00% <ø> (ø)
protocol-designer/src/file-data/selectors/utils.ts 79.58% <ø> (ø)
... and 201 more

... and 17 files with indirect coverage changes

@koji koji changed the title feat(protocol-designer): introduce alias to avoid using ../../../ [pending]feat(protocol-designer): introduce alias to avoid using ../../../ Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant