fix(shared-data): Correct some well geometries #17581
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17581 +/- ##
===========================================
- Coverage 63.08% 23.28% -39.81%
===========================================
Files 2840 2840
Lines 218766 218563 -203
Branches 18142 17944 -198
===========================================
- Hits 138010 50891 -87119
- Misses 80564 167659 +87095
+ Partials 192 13 -179
Flags with carried forward coverage won't be shown. Click here to find out more. |
The new values match the "LLD GEOMETRY LIBRARY" sheet.
15.04 matches the "LLD GEOMETRY LIBRARY" sheet and the sibling definition opentrons_24_tuberack_nest_2ml_snapcap.
SyntaxColoring
force-pushed
the
fix_frustum_stackups
branch
from
4cd12d6 to
9432d8d
Compare
SyntaxColoring
changed the title
|
|
SyntaxColoring
requested review from
TamarZanzouri and
a team
and removed request for
a team
Merging to fix tests.
|
Re-drafting while I double-check the other definitions too. |
opentrons_96_aluminumblock_nest_wellplate_100ul and opentrons_96_pcr_adapter_nest_wellplate_100ul_pcr_full_skirt have been deleted in edge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix some errors in unreleased labware definitions that I noticed while adding tests.
Test Plan and Hands on Testing
Just automated tests.
Changelog
opentrons_24_aluminumblock_nest_2ml_snapcap:opentrons_24_tuberack_nest_2ml_snapcap.The adapter + NEST well plate combo definitionsopentrons_96_aluminumblock_nest_wellplate_100ulandopentrons_96_pcr_adapter_nest_wellplate_100ul_pcr_full_skirt:Fix"topHeight": 0.2, "bottomHeight": 9.89—the values need to be swapped.After swapping, the values match what's in the "LLD GEOMETRY LIBRARY" sheet, and what's in the standalone definitionnest_96_wellplate_100ul_pcr_full_skirt.Update: we've just deleted these old definitions instead.
And add tests to catch these kinds of errors.
Review requests
Any reason I shouldn't be swiping measurements from the "LLD GEOMETRY LIBRARY" sheet right now?
Risk assessment
Low.