feat(shared-data, api): add stacker max fill height in shared-data definition #17609
+62
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17609 +/- ##
==========================================
- Coverage 25.71% 23.34% -2.37%
==========================================
Files 2843 2843
Lines 218900 218893 -7
Branches 17949 17949
==========================================
- Hits 56284 51096 -5188
- Misses 162601 167784 +5183
+ Partials 15 13 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vegano1
reviewed
Feb 27, 2025
|
|
||
| def get_height_of_stacker_labware_pool(self, module_id: str) -> float: | ||
| """Get the overall height of a stack of labware in a Stacker module.""" | ||
| stacker = self._modules.get_flex_stacker_substate(module_id) |
There was a problem hiding this comment.
stacker could be None here
There was a problem hiding this comment.
I didn't think we'd need to handle when it returns None because the only time this function will be called from a stacker command, and the command should fail anyway if there's no stacker attached?
vegano1
reviewed
Feb 27, 2025
|
|
||
| def get_stacker_max_fill_height(self, module_id: str): | ||
| """Get the maximum fill height for the Flex Stacker.""" | ||
| definition = self.get_definition(module_id) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The stacker's stackable labware count is limited by the interior height of the stacker.
This PR adds this property as the
maxStackerFillHeightin the module definition.The
flex_stacker/fillandflex_stacker/set_stored_labwarecommands are updated to use this property to calculate the actual max labware count based on the height of labware pool.