feat(app): Remove 'opentrons-' prefix in robot displayNames

app/src/components/ConnectPanel/RobotListItem.js

@@ -14,6 +14,7 @@ import type {RobotItemProps} from './RobotItem'
 export function RobotListItem (props: RobotItemProps) {
   const {
     name,
+    displayName,
     local,
     status,
     connected,
@@ -35,7 +36,7 @@ export function RobotListItem (props: RobotItemProps) {
           childClassName={styles.notification}
         />
 
-        <p className={styles.link_text}>{name}</p>
+        <p className={styles.link_text}>{displayName}</p>
 
         {connectable ? (
           <ToggleButton

app/src/components/ConnectPanel/UnreachableRobotItem.js

@@ -7,7 +7,7 @@ import RobotLink from './RobotLink'
 import styles from './styles.css'
 
 export default function UnreachableRobotItem (props: UnreachableRobot) {
-  const {name} = props
+  const {displayName} = props
   return (
     <li className={styles.robot_group}>
       <HoverTooltip
@@ -27,7 +27,7 @@ export default function UnreachableRobotItem (props: UnreachableRobot) {
               className={styles.robot_item_icon}
               disabled
             />
-            <p className={styles.link_text}>{name}</p>
+            <p className={styles.link_text}>{displayName}</p>
           </RobotLink>
         )}
       </HoverTooltip>

app/src/components/SessionHeader/index.js

@@ -7,11 +7,7 @@ import {getProtocolFilename} from '../../protocol'
 export default connect(mapStateToProps)(SessionHeader)
 
 function SessionHeader (props) {
-  return (
-    <Link to='/upload'>
-      {props.sessionName}
-    </Link>
-  )
+  return <Link to="/upload">{props.sessionName}</Link>
 }
 
 function mapStateToProps (state) {

app/src/discovery/__tests__/selectors.test.js

@@ -1,7 +1,13 @@
 // discovery selectors tests
 import * as discovery from '..'
 
-const makeFullyUp = (name, ip, status = null, connected = null) => ({
+const makeFullyUp = (
+  name,
+  ip,
+  status = null,
+  connected = null,
+  displayName = null
+) => ({
   name,
   ip,
   local: false,
@@ -12,9 +18,16 @@ const makeFullyUp = (name, ip, status = null, connected = null) => ({
   serverHealth: {},
   status,
   connected,
+  displayName,
 })
 
-const makeConnectable = (name, ip, status = null, connected = null) => ({
+const makeConnectable = (
+  name,
+  ip,
+  status = null,
+  connected = null,
+  displayName = null
+) => ({
   name,
   ip,
   local: false,
@@ -23,19 +36,27 @@ const makeConnectable = (name, ip, status = null, connected = null) => ({
   health: {},
   status,
   connected,
+  displayName,
 })
 
-const makeAdvertising = (name, ip, status = null) => ({
+const makeAdvertising = (name, ip, status = null, displayName = null) => ({
   name,
   ip,
   local: false,
   ok: false,
   serverOk: false,
   advertising: true,
   status,
+  displayName,
 })
 
-const makeServerUp = (name, ip, advertising, status = null) => ({
+const makeServerUp = (
+  name,
+  ip,
+  advertising,
+  status = null,
+  displayName = null
+) => ({
   name,
   ip,
   advertising,
@@ -44,16 +65,18 @@ const makeServerUp = (name, ip, advertising, status = null) => ({
   serverOk: true,
   serverHealth: {},
   status,
+  displayName,
 })
 
-const makeUnreachable = (name, ip, status = null) => ({
+const makeUnreachable = (name, ip, status = null, displayName = null) => ({
   name,
   ip,
   local: false,
   ok: false,
   serverOk: false,
   advertising: false,
   status,
+  displayName,
 })
 
 describe('discovery selectors', () => {
@@ -83,8 +106,8 @@ describe('discovery selectors', () => {
         robot: {connection: {connectedTo: 'bar'}},
       },
       expected: [
-        makeConnectable('foo', '10.0.0.1', 'connectable', false),
-        makeFullyUp('bar', '10.0.0.2', 'connectable', true),
+        makeConnectable('foo', '10.0.0.1', 'connectable', false, 'foo'),
+        makeFullyUp('bar', '10.0.0.2', 'connectable', true, 'bar'),
       ],
     },
     {
@@ -103,7 +126,9 @@ describe('discovery selectors', () => {
         },
         robot: {connection: {connectedTo: 'foo'}},
       },
-      expected: [makeConnectable('foo', '10.0.0.1', 'connectable', true)],
+      expected: [
+        makeConnectable('foo', '10.0.0.1', 'connectable', true, 'foo'),
+      ],
     },
     {
       name: 'getReachableRobots grabs robots with serverUp or advertising',
@@ -117,8 +142,8 @@ describe('discovery selectors', () => {
         },
       },
       expected: [
-        makeServerUp('foo', '10.0.0.1', false, 'reachable'),
-        makeAdvertising('bar', '10.0.0.2', 'reachable'),
+        makeServerUp('foo', '10.0.0.1', false, 'reachable', 'foo'),
+        makeAdvertising('bar', '10.0.0.2', 'reachable', 'bar'),
       ],
     },
     {
@@ -135,7 +160,7 @@ describe('discovery selectors', () => {
           },
         },
       },
-      expected: [makeServerUp('foo', '10.0.0.1', true, 'reachable')],
+      expected: [makeServerUp('foo', '10.0.0.1', true, 'reachable', 'foo')],
     },
     {
       name: 'getReachableRobots does not grab connectable robots',
@@ -165,9 +190,13 @@ describe('discovery selectors', () => {
       name: 'getUnreachableRobots grabs robots with no ip',
       selector: discovery.getUnreachableRobots,
       state: {
-        discovery: {robotsByName: {foo: [{name: 'foo', ip: null}]}},
+        discovery: {
+          robotsByName: {foo: [{name: 'foo', ip: null}]},
+        },
       },
-      expected: [{name: 'foo', ip: null, status: 'unreachable'}],
+      expected: [
+        {name: 'foo', ip: null, status: 'unreachable', displayName: 'foo'},
+      ],
     },
     {
       name: 'getUnreachableRobots grabs robots with IP but no responses',
@@ -182,7 +211,7 @@ describe('discovery selectors', () => {
           },
         },
       },
-      expected: [makeUnreachable('foo', '10.0.0.1', 'unreachable')],
+      expected: [makeUnreachable('foo', '10.0.0.1', 'unreachable', 'foo')],
     },
     {
       name: "getUnreachableRobots won't grab connectable/reachable robots",
@@ -208,6 +237,62 @@ describe('discovery selectors', () => {
       },
       expected: [],
     },
+    {
+      name: 'display name removes opentrons- from connectable robot names',
+      selector: discovery.getConnectableRobots,
+      state: {
+        discovery: {
+          robotsByName: {
+            'opentrons-foo': [makeConnectable('opentrons-foo', '10.0.0.1')],
+            'opentrons-bar': [makeFullyUp('opentrons-bar', '10.0.0.2')],
+          },
+        },
+        robot: {connection: {connectedTo: 'opentrons-bar'}},
+      },
+      expected: [
+        makeConnectable(
+          'opentrons-foo',
+          '10.0.0.1',
+          'connectable',
+          false,
+          'foo'
+        ),
+        makeFullyUp('opentrons-bar', '10.0.0.2', 'connectable', true, 'bar'),
+      ],
+    },
+    {
+      name: 'display name removes opentrons- from reachable robot names',
+      selector: discovery.getReachableRobots,
+      state: {
+        discovery: {
+          robotsByName: {
+            'opentrons-foo': [makeServerUp('opentrons-foo', '10.0.0.1', false)],
+            'opentrons-bar': [makeAdvertising('opentrons-bar', '10.0.0.2')],
+          },
+        },
+      },
+      expected: [
+        makeServerUp('opentrons-foo', '10.0.0.1', false, 'reachable', 'foo'),
+        makeAdvertising('opentrons-bar', '10.0.0.2', 'reachable', 'bar'),
+      ],
+    },
+    {
+      name: 'display name removes opentrons- from unreachable robot names',
+      selector: discovery.getUnreachableRobots,
+      state: {
+        discovery: {
+          robotsByName: {'opentrons-foo': [{name: 'opentrons-foo', ip: null}]},
+        },
+      },
+      expected: [
+        {
+          name: 'opentrons-foo',
+          ip: null,
+          status: 'unreachable',
+          displayName: 'foo',
+        },
+      ],
+    },
   ]
 
   SPECS.forEach(spec => {

app/src/discovery/selectors.js

@@ -59,17 +59,28 @@ const getGroupedRobotsMap: GetGroupedRobotsMap = createSelector(
     mapValues(robotsMap, services => {
       const servicesWithStatus = services.map(s => {
         const resolved = maybeGetResolved(s)
+        const displayName = makeDisplayName(s)
         if (resolved) {
-          if (isConnectable(resolved)) return {...s, status: CONNECTABLE}
-          if (isReachable(resolved)) return {...s, status: REACHABLE}
+          if (isConnectable(resolved)) {
+            return {...s, status: CONNECTABLE, displayName}
+          }
+          if (isReachable(resolved)) {
+            return {...s, status: REACHABLE, displayName}
+          }
         }
-        return {...s, status: UNREACHABLE}
+        return {...s, status: UNREACHABLE, displayName}
       })
 
       return groupBy(servicesWithStatus, 'status')
     })
 )
 
+function makeDisplayName (robot: Service) {
+  const {name} = robot
+  const displayName = name.replace('opentrons-', '')
+  return displayName
+}
+
 export const getConnectableRobots: GetConnectableRobots = createSelector(
   getGroupedRobotsMap,
   robotSelectors.getConnectedRobotName,

app/src/discovery/types.js

@@ -9,6 +9,7 @@ export type UnreachableStatus = 'unreachable'
 // service with a known IP address
 export type ResolvedRobot = {
   ...$Exact<Service>,
+  displayName: string,
   ip: $NonMaybeType<$PropertyType<Service, 'ip'>>,
   local: $NonMaybeType<$PropertyType<Service, 'local'>>,
   ok: $NonMaybeType<$PropertyType<Service, 'ok'>>,
@@ -34,6 +35,7 @@ export type ReachableRobot = {
 // robot with an unknown IP
 export type UnreachableRobot = {
   ...$Exact<Service>,
+  displayName: string,
   status: UnreachableStatus,
 }
 

app/src/pages/Robots/InstrumentSettings.js

@@ -19,18 +19,21 @@ export default function InstrumentSettingsPage (props: Props) {
     robot,
     match: {path, url},
   } = props
-  const titleBarProps = {title: robot.name}
+  const titleBarProps = {title: robot.displayName}
 
   return (
     <React.Fragment>
-    <Page titleBarProps={titleBarProps}>
-      <InstrumentSettings {...robot} />
-    </Page>
-    <Switch>
-      <Route path={`${path}/pipettes`} render={(props) => (
-        <ChangePipette {...props} robot={robot} parentUrl={url} />
-      )} />
-    </Switch>
+      <Page titleBarProps={titleBarProps}>
+        <InstrumentSettings {...robot} />
+      </Page>
+      <Switch>
+        <Route
+          path={`${path}/pipettes`}
+          render={props => (
+            <ChangePipette {...props} robot={robot} parentUrl={url} />
+          )}
+        />
+      </Switch>
     </React.Fragment>
   )
 }

app/src/pages/Robots/RobotSettings.js

@@ -74,7 +74,7 @@ function RobotSettingsPage (props: Props) {
     match: {path, url},
   } = props
 
-  const titleBarProps = {title: robot.name}
+  const titleBarProps = {title: robot.displayName}
   const updateUrl = `${url}/${UPDATE_FRAGMENT}`
   const calibrateDeckUrl = `${url}/${CALIBRATE_DECK_FRAGMENT}`
   const resetUrl = `${url}/${RESET_FRAGMENT}`