-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted all the css to into tailiwind css of HeroBanner page #1744
Converted all the css to into tailiwind css of HeroBanner page #1744
Conversation
Co-authored-by: Kyle Holmberg <inbox@kylemh.com>
…l-styling-with-Tailwind
Co-authored-by: Kyle Holmberg <inbox@kylemh.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 flaky test on run #4460 ↗︎
Details:
cypress/e2e/modal.spec.js • 1 flaky test • all tests
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! I added text-shadow support into our Tailwind config using the following blog's instructions: https://www.hyperui.dev/blog/text-shadow-with-tailwindcss
Then I noticed that on the home page HeroBanner was no longer full height, so I needed to add !important
to .Container.fullViewportHeight
to fix that.
You're really chipping away at this! Thanks so much for the help and I hope you don't mind me slapping these finishing touches on some of the PRs.
Code Climate has analyzed commit b557f58 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 75.7%. View more on Code Climate. |
Description of changes
Converted all the css to into tailiwind css of
HeroBanner
pageIssue - #1725
Issue Resolved
Fixes #NA
Screenshots/GIFs