Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted all the css to into tailiwind css of HeroBanner page #1744

Conversation

subhajit20
Copy link
Contributor

Description of changes

Converted all the css to into tailiwind css of HeroBanner page
Issue - #1725

Issue Resolved

Fixes #NA

Screenshots/GIFs

subhajit20 and others added 28 commits September 18, 2023 06:12
Co-authored-by: Kyle Holmberg <inbox@kylemh.com>
Co-authored-by: Kyle Holmberg <inbox@kylemh.com>
@vercel
Copy link

vercel bot commented Sep 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
operation-code ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2023 8:19am
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2023 8:19am

@cypress
Copy link

cypress bot commented Sep 24, 2023

1 flaky test on run #4460 ↗︎

0 35 0 0 Flakiness 1

Details:

ensure fullViewportHeight always wins
Project: operation_code Commit: b557f58c0d
Status: Passed Duration: 02:53 💡
Started: Sep 24, 2023 8:20 AM Ended: Sep 24, 2023 8:23 AM
Flakiness  cypress/e2e/modal.spec.js • 1 flaky test • all tests

View Output Video

Test Artifacts
when the server responds successfully > closes the modal when the x button is clicked Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@kylemh kylemh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I added text-shadow support into our Tailwind config using the following blog's instructions: https://www.hyperui.dev/blog/text-shadow-with-tailwindcss

Then I noticed that on the home page HeroBanner was no longer full height, so I needed to add !important to .Container.fullViewportHeight to fix that.

You're really chipping away at this! Thanks so much for the help and I hope you don't mind me slapping these finishing touches on some of the PRs.

@codeclimate
Copy link

codeclimate bot commented Sep 24, 2023

Code Climate has analyzed commit b557f58 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 75.7%.

View more on Code Climate.

@kylemh kylemh merged commit ae8068c into OperationCode:main Sep 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants