Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted all the css into Tailwind css of Drawer component #1745

Conversation

subhajit20
Copy link
Contributor

Description of changes

Converted all the css into Tailwind CSS of Drawer component.
issue - #1725

Issue Resolved

Fixes #NA

Screenshots/GIFs

subhajit20 and others added 30 commits September 18, 2023 06:12
Co-authored-by: Kyle Holmberg <inbox@kylemh.com>
Co-authored-by: Kyle Holmberg <inbox@kylemh.com>
@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
operation-code ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 4:32am
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 4:32am

@cypress
Copy link

cypress bot commented Sep 25, 2023

1 flaky test on run #4466 ↗︎

0 35 0 0 Flakiness 1

Details:

Converted all the css into Tailwind css of Drawer component
Project: operation_code Commit: 9e988e910a
Status: Passed Duration: 03:03 💡
Started: Sep 28, 2023 4:33 AM Ended: Sep 28, 2023 4:36 AM
Flakiness  cypress/e2e/modal.spec.js • 1 flaky test • all tests

View Output Video

Test Artifacts
when the server responds successfully > closes the modal when the x button is clicked Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

components/Drawer/Drawer.js Show resolved Hide resolved
components/Drawer/Drawer.js Outdated Show resolved Hide resolved
@subhajit20
Copy link
Contributor Author

@kylemh okay will do that.

Copy link
Member

@kylemh kylemh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this. Also, can you test your changes by starting the local dev server for the app? Right now, it's not visible.

components/Drawer/Drawer.js Outdated Show resolved Hide resolved
components/Drawer/Drawer.js Outdated Show resolved Hide resolved
components/Drawer/Drawer.js Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Sep 28, 2023

Code Climate has analyzed commit 9e988e9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 75.7% (0.0% change).

View more on Code Climate.

@kylemh kylemh merged commit 5145d77 into OperationCode:main Sep 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants