Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 page and podcast page #1766

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Fix 404 page and podcast page #1766

merged 2 commits into from
Nov 9, 2023

Conversation

kylemh
Copy link
Member

@kylemh kylemh commented Nov 9, 2023

Tryna fix the broken test. Also noticed that the 404 page looked broken, so I fixed that.

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
operation-code ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 3:14pm
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 3:14pm

@kylemh
Copy link
Member Author

kylemh commented Nov 9, 2023

Copy link

cypress bot commented Nov 9, 2023

1 flaky test on run #4509 ↗︎

0 35 0 0 Flakiness 1

Details:

update snapshot tests
Project: operation_code Commit: 60b6a60fd5
Status: Passed Duration: 03:28 💡
Started: Nov 9, 2023 3:15 PM Ended: Nov 9, 2023 3:18 PM
Flakiness  cypress/e2e/modal.spec.js • 1 flaky test • all tests

View
Output
Video

Test Artifacts
when the server responds successfully > closes the modal when the x button is clicked Screenshots Video

Review all test suite changes for PR #1766 ↗︎

Copy link

codeclimate bot commented Nov 9, 2023

Code Climate has analyzed commit 60b6a60 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 75.6%.

View more on Code Climate.

@kylemh kylemh merged commit 1245699 into main Nov 9, 2023
4 checks passed
@kylemh kylemh deleted the kylemh/fix-pages branch November 9, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant