This repository was archived by the owner on Sep 4, 2018. It is now read-only.
Feature/tests less reliant on copy #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests still expect the `new` method to be called, and to return a value. It simply no longer strictly expects the `new` method to be called with a specific paragraph of text. This allows for flexibility in changing the text of the message, while still testing that the methods are being called.
hollomancer
approved these changes
Oct 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests are randomly failing when a message's text is changed. This PR removes the expectation of a precise message.
The tests still expect the
newmethod to be called, and to return a value. It simply no longer strictly expects thenewmethod to be called with a specific paragraph of text.This allows for flexibility in changing the text of the message, while still testing that the methods are being called.
In addition to that, this PR:
.DS_StoretogitignoregemfileIssue Resolved
Fixes #84