Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDK qa.json file #42

Draft
wants to merge 2 commits into
base: aws-migration
Choose a base branch
from
Draft

Conversation

MikkoKauhanen
Copy link
Contributor

This PR is preparation for CDK deployment to QA env

Copy link
Contributor

@hsalokor hsalokor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ei huomioita, voi minusta mergetä.

"KAFKA_CLIENT_ID": "aoe-web-backend",
"KAFKA_CLIENT_REGION": "eu-west-1",

"SESSION_COOKIE_DOMAIN":".aoe.fi",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huomio: tämän voisi ehkä sitten testata että tuleeko dev vs qa välillä jotain autentikaatiokonfliktia, toisin sanoen tarviiko cookie domainin olla esim dev.aoe.fi ja qa.aoe.fi vai osaako selain käsitellä ne erikseen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants