forked from spinnaker/gate
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Op-21723:CVE-fixes with java-17 and spring-boot upgrade-v4.1 #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and made disabled authConfig to false
gate-basic/src/main/java/com/netflix/spinnaker/gate/security/basic/BasicAuthProvider.java
Show resolved
Hide resolved
gate-saml/src/main/groovy/com/opsmx/spinnaker/gate/security/saml/SamlSsoConfig.groovy
Outdated
Show resolved
Hide resolved
gate-saml/src/main/java/com/opsmx/spinnaker/gate/security/saml/Saml2UserDetails.java
Outdated
Show resolved
Hide resolved
gate-saml/src/main/java/com/opsmx/spinnaker/gate/security/saml/SamlSecurityConfiguration.java
Show resolved
Hide resolved
gate-web/src/main/groovy/com/netflix/spinnaker/gate/controllers/OpsmxAuthController.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address the highlighted issue.
rahul-chekuri
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://devopsmx.atlassian.net/browse/OP-21936
OP-21881 involves fixing CVE issues by upgrading to Java 17 and Spring Boot v4.1 .
Since the Fiat service is not utilized in ISD-Argo, I removed the Fiat code from the ISD-Argo Gate Service. However, during this removal process, the /auth/user API stopped returning user details, causing the UI to refresh repeatedly. We resolved this issue by adding "return user" to the code, ensuring that the API now returns the necessary user information without triggering excessive UI refreshing and incorporating a few configurations in the secret settings.