OP-22232: Added support for secure redis connection #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| System.out.println("Certificate has been added to the KeyStore successfully."); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
There is no point in proceeding with service initialization when an exception is caught, so please throw the exception appropriately.
| keyStore.store(jksOutputStream, password); | ||
| jksOutputStream.close(); | ||
|
|
||
| System.out.println("Certificate has been added to the KeyStore successfully."); |
|
|
||
| FileOutputStream jksOutputStream = new FileOutputStream(jksFilePath); | ||
| keyStore.store(jksOutputStream, password); | ||
| jksOutputStream.close(); |
There was a problem hiding this comment.
this should be in finally clause.
| CertificateFactory certificateFactory = CertificateFactory.getInstance("X.509"); | ||
| FileInputStream certInputStream = new FileInputStream(certFilePath); | ||
| Certificate certificate = certificateFactory.generateCertificate(certInputStream); | ||
| certInputStream.close(); |
There was a problem hiding this comment.
this should be in finally clause.
| String alias = "redis-truststore"; // An alias to identify the certificate in the keystore | ||
| char[] password = this.password.toCharArray(); // Keystore password | ||
|
|
||
| try { |
There was a problem hiding this comment.
Please write some comments clarifying the steps down below.
rahul-chekuri
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.