Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mapNotnull and maxOrNull to handle completedPipelineKeys in Pee… #40

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Added mapNotnull and maxOrNull to handle completedPipelineKeys in Pee… #40

merged 1 commit into from
Jan 8, 2024

Conversation

aman-agrawal
Copy link
Collaborator

Summary

Project Jira : Ref
Project Doc : NA

Issue : 6/42 TCs failing in orca-peering

java.util.NoSuchElementException
	at kotlin.collections.CollectionsKt___CollectionsKt.maxOrThrow(_Collections.kt:1916)
	at com.netflix.spinnaker.orca.peering.PeeringAgent.doMigrate$getLatestCompletedUpdatedTime(PeeringAgent.kt:258)
	at com.netflix.spinnaker.orca.peering.PeeringAgent.doMigrate(PeeringAgent.kt:280)
	at com.netflix.spinnaker.orca.peering.PeeringAgent.peerCompletedExecutions(PeeringAgent.kt:168)
	at com.netflix.spinnaker.orca.peering.PeeringAgentSpec.correctly computes the execution diff for completed #executionType(PeeringAgentSpec.groovy:91)

Solution : By using mapNotNull and maxOrNull, we ensure that the code gracefully handles the case when completedPipelineKeys is empty or when there are null values in the updated_at properties

How changes are verified

build successful & 42/42 TCs are passing in orca-peering

Documentation Updates

Do we need to update dashboards? No
Do we need to update SOP, new hire wiki or other documents? No

Rollback, Deployment Details

Can this change be rolled back automatically without any issue? Yes
Is this a backwards-compatible change in your opinion ? Yes
Pre deployment steps : NA
Post deployment steps : NA

@sanopsmx sanopsmx merged commit e591262 into OpsMx:OES-1.30.1 Jan 8, 2024
1 check failed
sanopsmx pushed a commit that referenced this pull request Jun 4, 2024
* Bugfix added configurable timeout value for MonitorFront50Task

* OP-20611: Bugfix added configurable timeout value for save pipeline task timeout
sanopsmx pushed a commit that referenced this pull request Jun 4, 2024
* Bugfix added configurable timeout value for MonitorFront50Task

* OP-20611: Bugfix added configurable timeout value for save pipeline task timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants