Added code for manual judgment api implementation #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebalag
reviewed
Apr 6, 2021
| @@ -89,14 +94,21 @@ class ManualJudgmentStage implements StageDefinitionBuilder, AuthenticatedStage | |||
| String notificationState | |||
| ExecutionStatus executionStatus | |||
|
|
|||
| if (runOnlyOnce) { | |||
| checkForAnyParentExecution(stage) | |||
| runOnlyOnce = false | |||
There was a problem hiding this comment.
not sure of use for runOnlyOnce
Does this method execute outside state change for manual judgement ? Why cannot we move this code into the switch statement and eliminate runOnlyOnce variable ?
Should we clear the additional key/values set in stages when the manual judgement completes ?
There was a problem hiding this comment.
The latest code will address these issues.
…ll the parent pipelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code for inserting leafnodeExecutionId and leafnodeApplicationName into all the parent pipelines.