Support useragent override in the constructor #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmilekic
force-pushed
the
23-useragent-override
branch
from
1c5de45 to
f7138f1
Compare
When initializing the `OptableSDK` constructor, it's now possible to override the otherwise internally assigned user-agent string, with one specified by the caller. The caller-specified useragent is of course optional and, if one is not assigned (or nil is passed as the useragent at initialization time) then the default is to continue to create an invisible WebView and extract the user-agent string from it. If a caller specifies a non-nil useragent string, then we use it instead. Closes #23 Documented in README
bmilekic
force-pushed
the
23-useragent-override
branch
from
f7138f1 to
f37f50c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing the
OptableSDKconstructor, it's now possible to override the otherwise internally assigned user-agent string, with one specified by the caller. The caller-specified useragent is of course optional and, if one is not assigned (or nil is passed as the useragent at initialization time) then the default is to continue to create an invisible WebView and extract the user-agent string from it. If a caller specifies a non-nil useragent string, then we use it instead.Closes #23