Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user_script:70: too many results to unpack #2764

Labels

Comments

@matt-moven
Copy link

matt-moven commented Aug 27, 2024

Description

See #2709 for reference

We also ran into this bug and traced it down to the collectMetrics function in "moveToFinished-9.lua". We set metrics.maxDataPoints to 1. In moveToFinished, collectMetrics tries to add the current metric and also fill in zero values for all the missed seconds, and then trims that list down to maxDataPoints. If a queue sees no jobs for enough time, and then processes a job and tries to update its metrics, the unpack() with one metric and many zeros fails with error "too many results to unpack".

rcall("LPUSH", dataPointsList, unpack(points))

Since the metric prevTS is not updated, all following jobs in the queue also throw the error.

Bull version

4.16.0

github-actions bot pushed a commit that referenced this issue Aug 28, 2024
## [4.16.1](v4.16.0...v4.16.1) (2024-08-28)

### Bug Fixes

* **metrics:** use batches include when collecting metrics ([#2765](#2765)) fixes [#2764](#2764) [#2763](#2763) ([8276f72](8276f72))
@manast
Copy link
Member

manast commented Aug 28, 2024

🎉 This issue has been resolved in version 4.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment