Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document createClient option #1791

Merged
merged 6 commits into from
Jul 21, 2020
Merged

Document createClient option #1791

merged 6 commits into from
Jul 21, 2020

Conversation

dobesv
Copy link
Contributor

@dobesv dobesv commented Jul 3, 2020

Fix for #1747

@coveralls
Copy link

coveralls commented Jul 3, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 95.396% when pulling 52e5be6 on dobesv:patch-5 into dfc9211 on OptimalBits:develop.

manast
manast requested changes Jul 20, 2020
View reviewed changes
REFERENCE.md Outdated Show resolved Hide resolved
@manast
Copy link
Member

manast commented Jul 20, 2020

thanks for this great improvement, please check one small comment I made.

dobesv
dobesv commented Jul 20, 2020
View reviewed changes
REFERENCE.md Outdated Show resolved Hide resolved
dobesv
dobesv commented Jul 20, 2020
View reviewed changes
REFERENCE.md Outdated Show resolved Hide resolved
joebowbeer
joebowbeer approved these changes Jul 20, 2020
View reviewed changes
Copy link

@joebowbeer joebowbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - suggested param name change to match code.

REFERENCE.md Outdated Show resolved Hide resolved
dobesv and others added 2 commits July 20, 2020 16:41
@dobesv @joebowbeer
redisOpts -> config
2fb3a23 
Co-authored-by: Joe Bowbeer <joe.bowbeer@gmail.com>
@manast
Merge branch 'develop' into patch-5
52e5be6
@manast manast merged commit c23ed74 into OptimalBits:develop Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manast manast manast requested changes

@joebowbeer joebowbeer joebowbeer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dobesv @coveralls @manast @joebowbeer