Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix algorithm for dynamic reference resolution #101

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

OptimumCode
Copy link
Owner

Resolves #100

@OptimumCode OptimumCode added the fix Fix for bug label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.10%. Comparing base (dd07900) to head (65907fc).
Report is 1 commits behind head on main.

Files Patch % Lines
...b/optimumcode/json/schema/internal/SchemaLoader.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   90.10%   90.10%           
=======================================
  Files         108      108           
  Lines        2779     2770    -9     
  Branches      778      772    -6     
=======================================
- Hits         2504     2496    -8     
  Misses         48       48           
+ Partials      227      226    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OptimumCode OptimumCode enabled auto-merge (squash) April 22, 2024 17:34
@OptimumCode OptimumCode merged commit e458073 into main Apr 22, 2024
8 checks passed
@OptimumCode OptimumCode deleted the issue_#100 branch April 22, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: implementation doesn’t pass new dynamicRef test suites
1 participant