Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for uri and iri formats #99

Merged
merged 17 commits into from
Apr 26, 2024
Merged

Add support for uri and iri formats #99

merged 17 commits into from
Apr 26, 2024

Conversation

OptimumCode
Copy link
Owner

Related to #54

@OptimumCode OptimumCode added the enhancement New feature or request label Apr 19, 2024
@OptimumCode OptimumCode force-pushed the uri-and-iri-formats branch from 01342d1 to 4ec1371 Compare April 19, 2024 18:42
@OptimumCode OptimumCode marked this pull request as draft April 19, 2024 18:43
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 88.42730% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 89.92%. Comparing base (e458073) to head (49d764b).

Files Patch % Lines
...ema/internal/formats/UriTemplateFormatValidator.kt 76.85% 0 Missing and 25 partials ⚠️
...ptimumcode/json/schema/internal/formats/UriSpec.kt 90.41% 5 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   90.10%   89.92%   -0.19%     
==========================================
  Files         108      115       +7     
  Lines        2770     3107     +337     
  Branches      772      916     +144     
==========================================
+ Hits         2496     2794     +298     
- Misses         48       53       +5     
- Partials      226      260      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OptimumCode OptimumCode force-pushed the uri-and-iri-formats branch from 3fe59b2 to 554cbc4 Compare April 22, 2024 06:58
@OptimumCode OptimumCode force-pushed the uri-and-iri-formats branch from 554cbc4 to db39e65 Compare April 23, 2024 18:31
@OptimumCode OptimumCode marked this pull request as ready for review April 26, 2024 08:33
@OptimumCode OptimumCode merged commit cb90f5e into main Apr 26, 2024
9 checks passed
@OptimumCode OptimumCode deleted the uri-and-iri-formats branch April 26, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant