This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
Add Django 4.1 support #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
commented
Aug 25, 2022
| envlist = | ||
| clean | ||
| py37-django{22,32} | ||
| py{38,39,310}-django{22,32,40,41} |
There was a problem hiding this comment.
the previous config was missing py for these versions - it would just generate e.g. 38-django22, which I think doesn't affect the Python version. So my guess is your tests have not been running with different Python versions for these environments.
Comment on lines
+34
to
+38
| "Framework :: Django", | ||
| "Framework :: Django :: 2.2", | ||
| "Framework :: Django :: 3.2", | ||
| "Framework :: Django :: 4.0", | ||
| "Framework :: Django :: 4.1", |
There was a problem hiding this comment.
adding classifiers helps advertise which versions the package is tested on
This was referenced Aug 25, 2022
|
I alos hit the error in #12 when actually trying to run the affected project on Django 4.1. Anyway will look at dropping django-pgconnection. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.