Left tool drawing preview is not visible when right tool has preview

[kazardous]

Pixelorama version:

Tested on 033238b and v1.0.5-stable

Where did you download Pixelorama from?

Github

OS/device including version:

Tested on Debian 12 and Windows 10

Issue description:

I selected two tools that show a drawing preview on both left and right click, e.g. Line tool and Lasso, and the left tool drawing preview is not visible when drawing as would be expected. Only the right tool drawing preview is visible when drawing.

This bug seems to affect any line, shape, or selection tool that has a drawing preview, the only exception is the rectangular selection tool, which behaves as expected.

Affected tools:

• Elliptical Selection
• Polygonal Selection
• Lasso / Free Select Tool
• Select by Drawing
• Line Tool
• Curve Tool
• Rectangle Tool
• Ellipse Tool

Examples with selecting the same tool on left/right and using left tool, then right tool:

Steps to reproduce:

• Select any of the listed affected tools above as both left and right click tools, e.g. Line tool on left, Lasso on right
• Draw on the canvas with the left tool and the drawing preview will not be visible

[kazardous]

This can be fixed with a (quick and dirty) check on draw preview. I've done this here but this was before I realized the select tools are affected and the rectangular selection tool is an exception to this bug. So I haven't started a PR with this change yet to look at how rectangular selection handles it.

[OverloadedOrama]

Thank you so much for finding the bug! I had gotten reports that the tool preview was sometimes not being shown and I had no idea what caused it. I suppose this must be the root of the issue. I believe 59254b9 should be enough to fix the issue, hopefully I didn't break anything else, feel free to let me know if you encounter any issues!

[OverloadedOrama]

My bad, that commit did not fix the issue for all tools. a698668 should now also fix the curve and polygon selection tools.

[kazardous]

Amazing! You're very welcome, glad I could help narrow it down. I've just tested this and can confirm this fixes all previews.