Fix layouts overwriting the position info of panels, added by extensions. #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OverloadedOrama
changed the title
OverloadedOrama
approved these changes
Feb 5, 2025
OverloadedOrama
merged commit ec7155c
into
Orama-Interactive:master
3 of 4 checks passed
OverloadedOrama
added a commit
that referenced
this pull request
Feb 8, 2025
Possible regression from #1172.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the layout change was done too early, before the extension adding the panel.
As the panel always initially gets added to the left most side (which is different form it's last closed position, where we moved the panel), it gets counted as a change and the layout overwrote/reset the panel's position