Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotation improvements #676

Merged
merged 15 commits into from
Apr 27, 2022
Merged

Rotation improvements #676

merged 15 commits into from
Apr 27, 2022

Conversation

Variable-ind
Copy link
Contributor

@Variable-ind Variable-ind commented Apr 24, 2022 •
edited by OverloadedOrama
Loading

This pull addresses these two issues

  1. The pivot was being set wrong in case of even lengths resulting in a 1px gap
  2. The Image boundaries were being cropped during "scale_3x() method" in (upscale rotate downscale)

Old implementation rotated 90 degrees
Before

New implementation rotated 90 degrees
After

Maintainer edit: Fixes #675.

OverloadedOrama
OverloadedOrama approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@OverloadedOrama OverloadedOrama merged commit b9a841a into Orama-Interactive:master Apr 27, 2022
@Variable-ind Variable-ind deleted the rotation_improvements branch April 28, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverloadedOrama OverloadedOrama OverloadedOrama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rotating image by multiples of 90 degrees is broken.
2 participants
@Variable-ind @OverloadedOrama