New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix id_map error on open_pxo_file as well as grid being wrong size #765

Merged

OverloadedOrama merged 1 commit into Orama-Interactive:master from mrtripie:id_map_and_grid_size_fix_on_open_pxo

Oct 16, 2022

Contributor

mrtripie commented Oct 14, 2022

This fixes this error that showed up in the #698 PR when opening a pxo file (without any changes to the empty default file):

E 0:00:11.149   getornull: Condition "!id_map.has(p_rid.get_data())" is true. Returned: nullptr
  <C++ Source>  ./core/rid.h:151 @ getornull()

This was caused by Global.canvas.update() not being called

Also fixes the grid not being updated, and maybe other bugs.

Not sure if just using the Project.change_project() will cause other issues though

Fix

4a80e3d

OverloadedOrama approved these changes

View reviewed changes

Member

OverloadedOrama left a comment

Thanks!

OverloadedOrama merged commit 0faacaf into Orama-Interactive:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet