Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Continuation] Auto select cloned frames, reuse tag animations #861

Merged
merged 35 commits into from
Jun 15, 2023

Conversation

Variable-ind
Copy link
Contributor

@Variable-ind Variable-ind commented May 16, 2023

Continuation of #648,
in the original pull request i wanted that on cloning, the newly cloned frames are all selected by default so that if one wishes to clone animations (as shown below) then this would make it easier but i gave up half way cause i couldn't figure out how...

with my recent attempt, i've successfully implemented this feature

Applications:

  1. easily create animations with twice the speed
feature.mp4
  1. Another useful application of this is to easily create animations similar to the one in the video below (if you analyze the video, you will notice many instances where a single animation is played again and again with an offset which as a whole makes it beautiful) https://youtu.be/Kh-KrYun8SY

@Variable-ind Variable-ind changed the title [Targeted for 0.11.0][Continuation] Auto select cloned frames by default [Targeted for 0.11.0][Continuation] Auto select cloned frames, reuse tag animationd May 17, 2023
@Variable-ind
Copy link
Contributor Author

with the cels now being selected automatically, i also took the liberty of adding the ability to re-use already existing tag animations as you see below

test.mp4

@Variable-ind Variable-ind changed the title [Targeted for 0.11.0][Continuation] Auto select cloned frames, reuse tag animationd [Targeted for 0.11.0][Continuation] Auto select cloned frames, reuse tag animations May 17, 2023
@Variable-ind Variable-ind changed the title [Targeted for 0.11.0][Continuation] Auto select cloned frames, reuse tag animations [Continuation] Auto select cloned frames, reuse tag animations May 27, 2023
@@ -309,6 +310,7 @@ size_flags_horizontal = 3
margin_right = 677.0
margin_bottom = 38.0
size_flags_horizontal = 3
theme = SubResource( 20 )
Copy link
Member

@OverloadedOrama OverloadedOrama Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the changes in the AnimationTimeline scene in this PR are undoing the changes in commit 361fe36, which removed the custom theme for the AnimationToolsScrollContainer node. I'd recommend merging the latest master branch to your branch (or rebasing), then reverting AnimationTimeline.tscn (to be the same as the master branch's), and then re-adding the new PasteTagPopup node, to ensure no conflicts will occurr.

Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@OverloadedOrama OverloadedOrama merged commit b759032 into Orama-Interactive:master Jun 15, 2023
@Variable-ind Variable-ind deleted the select_frames branch June 15, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants