Skip to content
This repository has been archived by the owner on Sep 28, 2023. It is now read-only.

[alerts] — Remove inner span #167

Closed
ffoodd opened this issue Feb 12, 2020 · 0 comments · Fixed by #166
Closed

[alerts] — Remove inner span #167

ffoodd opened this issue Feb 12, 2020 · 0 comments · Fixed by #166
Assignees
Labels
Milestone

Comments

@ffoodd
Copy link
Contributor

ffoodd commented Feb 12, 2020

The duplicated cross when upgrading to Boosted 4.4.1 is due to a diff between Boosted and Bootstrap (thus ng-bootstrap).

The current Boosted pattern is:

<div class="alert alert-lg alert-danger alert-dismissible fade show mb-0" role="alert">
    <span class="alert-icon"><span class="sr-only">Danger</span></span>
    <div>
        <h4 class="alert-heading">Error notification text goes here.</h4>
        <p>Description text goes here.</p>
    </div>
    <button type="button" class="close" data-dismiss="alert">
        <span class="sr-only">Close alert message</span>
    </button>
</div>

There's a first step to remove the unwanted cross, in CSS:

.close > [aria-hidden="true"]  {
    display: none;
}

Which will solve the visual inconsistency.

However there's a second step which should be done to match Boosted, but it requires to override the generated markup from ng-bootstrap's alert.

@ffoodd ffoodd added the Boosted label Feb 12, 2020
@ffoodd ffoodd added this to the Boosted 4.4.1 milestone Feb 12, 2020
@ffoodd ffoodd linked a pull request Feb 12, 2020 that will close this issue
@ffoodd ffoodd assigned ffoodd and unassigned ffoodd Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants