This repository has been archived by the owner on Sep 28, 2023. It is now read-only.
fix: ONavMenuComponent selector #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: change ONavMenuComponent selector from `lib-li[o-nav-menu]` to `li[o-nav-menu]` to be usable add: tslint disable component-selector rule for the selector name of ONavMenuComponent fix #117
|
You can preview your changes Building with commit a05d65c https://app.netlify.com/sites/youthful-allen-8a6081/deploys/5da6cca1d21c680008c70d7f |
fix: when an event trigger on OCarouselContainerComponent before swiper being initialized, it throw errors this commit tries to prevent that by add save checks to make sure that swiper is defined before it tries to stop/start the autoplay fix #120
|
@BehnooshShiva @Lausselloic if the o-nav-menu part won't get merged i can make new PL just for the swiper check |
|
@robertIsaac |
|
pull request #119 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: change ONavMenuComponent selector from
lib-li[o-nav-menu]toli[o-nav-menu]to be usableadd: tslint disable component-selector rule for the selector name of ONavMenuComponent
fix #117