Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "Close" tooltip to close buttons #1823

Merged
merged 35 commits into from
Jun 19, 2023
Merged

Add a "Close" tooltip to close buttons #1823

merged 35 commits into from
Jun 19, 2023

Commits on Feb 7, 2023

  1. Add tooltip on close btn for button close + modals + alerts + toasts … 

    …+ offcanvas.

Needed to add js to manage tooltip on live alert's btn-close
Still have to fix tooltip z-index on toasts when inside toast container
    @hannahiss
    hannahiss committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    fae518d View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Remove duplicate disabled attribute to unblock Netlify

    @julien-deramond
    julien-deramond committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    0ffd826 View commit details
    Browse the repository at this point in the history

  2. move disabled attribute

    @hannahiss
    hannahiss committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    aa26488 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into main-his-close-btn-tooltip

    @hannahiss
    hannahiss committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    57c4210 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Merge branch 'main' into main-his-close-btn-tooltip

    @hannahiss
    hannahiss committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    b86e9d1 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Changes after LM review: 

    - change js to select all btn-close
- add data-bs-container for some toasts to resolve z-index pbs
- change js-dismiss short code 2nd example: remove btn-close class and make it a standard button (with no tooltip)
- enhance migration guide
    @hannahiss
    hannahiss committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    3b7271d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into main-his-close-btn-tooltip

    @hannahiss
    hannahiss authored Mar 7, 2023
    Configuration menu
    Copy the full SHA
    f2289a8 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Merge branch 'main' into main-his-close-btn-tooltip

    @hannahiss
    hannahiss authored Mar 13, 2023
    Configuration menu
    Copy the full SHA
    40cdfc9 View commit details
    Browse the repository at this point in the history

  2. Stick to btn-close for 2nd button

    @hannahiss
    hannahiss committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    0fe22c7 View commit details
    Browse the repository at this point in the history

  3. Add tooltip to 2nd button since it's a "cross" close button

    @hannahiss
    hannahiss committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    ba8b92b View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Merge branch 'main' into main-his-close-btn-tooltip

    @hannahiss
    hannahiss committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    e2331b0 View commit details
    Browse the repository at this point in the history

  2. Changes after LM review: 

    - enhance migration guide
- simplify and enhance js
    @hannahiss
    hannahiss committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    10faad0 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Merge branch 'main' into main-his-close-btn-tooltip

    @hannahiss
    hannahiss committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    51b2693 View commit details
    Browse the repository at this point in the history

  2. Add missing piece of js for btn-close tooltip on live alerts + have e… 

    …xactly the same code in snippets and documentation (to avoid errors)
    @hannahiss
    hannahiss committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    45545d5 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Merge branch 'main' into main-his-close-btn-tooltip

    @hannahiss
    hannahiss committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    2e15627 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Merge branch 'main' into main-his-close-btn-tooltip 

    # Conflicts:
#	site/assets/js/snippets.js
#	site/content/docs/5.3/components/alerts.md
    @hannahiss
    hannahiss committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    28945b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Merge branch 'main' into main-his-close-btn-tooltip

    @MewenLeHo
    MewenLeHo authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    3ccef48 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Merge branch 'main' into main-his-close-btn-tooltip

    @hannahiss
    hannahiss authored May 2, 2023
    Configuration menu
    Copy the full SHA
    c778d27 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Merge branch 'main' into main-his-close-btn-tooltip

    @julien-deramond
    julien-deramond authored May 12, 2023
    Configuration menu
    Copy the full SHA
    30d25c8 View commit details
    Browse the repository at this point in the history

  2. Julien's review: 

    - Add stackblitz_add_js="true" for examples that require it to ensure the tooltip works on Stackblitz
- correction of the code style and comments
    @hannahiss
    hannahiss committed May 12, 2023
    Configuration menu
    Copy the full SHA
    3d6bbcb View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Merge branch 'main' into main-his-close-btn-tooltip 

    # Conflicts:
#	site/content/docs/5.3/migration.md
    @hannahiss
    hannahiss committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    368aa00 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Merge branch 'main' into main-his-close-btn-tooltip

    @julien-deramond
    julien-deramond authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    1443b2f View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Merge branch 'main' into main-his-close-btn-tooltip 

    # Conflicts:
#	site/content/docs/5.3/migration.md
    @hannahiss
    hannahiss committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    19802c8 View commit details
    Browse the repository at this point in the history

  2. - add close button in the list of js components

    @hannahiss
    hannahiss committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    cf36e8e View commit details
    Browse the repository at this point in the history

  3. enhance migration guide + snippets

    @hannahiss
    hannahiss committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    334e7a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Fix typo

    @julien-deramond
    julien-deramond committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    7511f31 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Merge branch 'main' into main-his-close-btn-tooltip

    @hannahiss
    hannahiss authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    021d1e1 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Merge branch 'main' into main-his-close-btn-tooltip

    @hannahiss
    hannahiss committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    b4fba8b View commit details
    Browse the repository at this point in the history

  2. Add more info in migration guide and docs about close button tooltip … 

    …usage and enabling
    @hannahiss
    hannahiss committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    cd274e6 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Consistency in introduction wording

    @julien-deramond
    julien-deramond committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    460279b View commit details
    Browse the repository at this point in the history

  2. Move migration note from navs and tabs to navbar

    @julien-deramond
    julien-deramond committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    43a914b View commit details
    Browse the repository at this point in the history

  3. .

    @julien-deramond
    julien-deramond committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    ed287f0 View commit details
    Browse the repository at this point in the history

  4. put info about enabling tooltip on close button in a shortcode

    @hannahiss
    hannahiss committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    13c64c9 View commit details
    Browse the repository at this point in the history

  5. Enhance enable-btn-close-tooltip

    @julien-deramond
    julien-deramond committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    11e6b7d View commit details
    Browse the repository at this point in the history

  6. move "enable tooltip" before "options"

    @hannahiss
    hannahiss committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    fd33bb5 View commit details
    Browse the repository at this point in the history